ФУНКЦИИ - МЕЖПРОЕКТНАЯ КОММУНИКАЦИЯ: blob-дедупликация файлов

plane-src/apps/api/plane/app/views/issue/attachment.py

@@ -23,10 +23,10 @@ from plane.db.models import FileAsset, Workspace
 from plane.bgtasks.issue_activities_task import issue_activity
 from plane.app.permissions import allow_permission, ROLE
 from plane.settings.storage import S3Storage
-from plane.bgtasks.storage_metadata_task import get_asset_object_metadata
 from plane.utils.host import base_host
 from plane.utils.upload_limits import resolve_workspace_upload_size_limit
 from plane.utils.attachment_preview import attachment_object_exists, get_attachment_preview_response
+from plane.utils.file_dedup import finalize_uploaded_file_asset, release_file_asset_blob, UploadedObjectMissing
 
 
 class IssueAttachmentEndpoint(BaseAPIView):
@@ -69,7 +69,9 @@ class IssueAttachmentEndpoint(BaseAPIView):
                 {"error": "Issue attachment not found."},
                 status=status.HTTP_404_NOT_FOUND,
             )
-        issue_attachment.asset.delete(save=False)
+        release_result = release_file_asset_blob(issue_attachment, request=request)
+        if not release_result.had_blob:
+            issue_attachment.asset.delete(save=False)
         issue_attachment.delete()
         issue_activity.delay(
             type="attachment.activity.deleted",
@@ -155,9 +157,11 @@ class IssueAttachmentV2Endpoint(BaseAPIView):
     @allow_permission([ROLE.ADMIN], creator=True, model=FileAsset)
     def delete(self, request, slug, project_id, issue_id, pk):
         issue_attachment = FileAsset.objects.get(pk=pk, workspace__slug=slug, project_id=project_id)
+        if not issue_attachment.is_uploaded:
+            release_file_asset_blob(issue_attachment, request=request, delete_untracked_object=True)
         issue_attachment.is_deleted = True
         issue_attachment.deleted_at = timezone.now()
-        issue_attachment.save()
+        issue_attachment.save(update_fields=["is_deleted", "deleted_at", "updated_at"])
 
         issue_activity.delay(
             type="attachment.activity.deleted",
@@ -225,12 +229,14 @@ class IssueAttachmentV2Endpoint(BaseAPIView):
                 origin=base_host(request=request, is_app=True),
             )
 
-            # Update the attachment
-            issue_attachment.is_uploaded = True
             issue_attachment.created_by = request.user
+            issue_attachment.save(update_fields=["created_by", "updated_at"])
 
-        # Get the storage metadata
-        if not issue_attachment.storage_metadata:
-            get_asset_object_metadata.delay(str(issue_attachment.id))
-        issue_attachment.save()
+        try:
+            finalize_uploaded_file_asset(issue_attachment, request=request)
+        except UploadedObjectMissing:
+            return Response(
+                {"error": "The uploaded attachment object was not found.", "status": False},
+                status=status.HTTP_400_BAD_REQUEST,
+            )
         return Response(status=status.HTTP_204_NO_CONTENT)